Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colon in doc notes #3796

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Jul 29, 2020

Fix various notes that end up putting the colon after the header like here: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/kms_secret_ciphertext

Release Note Template for Downstream PRs (will be copied)


@google-cla google-cla bot added the cla: yes label Jul 29, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 16 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 15 files changed, 16 insertions(+), 16 deletions(-))
Ansible: Diff ( 2 files changed, 10 insertions(+), 10 deletions(-))
Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=136487"

@c2thorn c2thorn requested a review from megan07 July 29, 2020 18:58
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 16 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 15 files changed, 16 insertions(+), 16 deletions(-))
Ansible: Diff ( 2 files changed, 10 insertions(+), 10 deletions(-))
Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=136503"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccActiveDirectoryDomain_update|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterInterface_basic|TestAccEndpointsService_basic You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=136504"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants